Open
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2261 +/- ##
=========================================
Coverage 82.16% 82.16%
- Complexity 4822 4830 +8
=========================================
Files 472 477 +5
Lines 15036 15054 +18
Branches 1905 1905
=========================================
+ Hits 12354 12369 +15
- Misses 1989 1993 +4
+ Partials 693 692 -1
🚀 New features to boost your workflow:
|
📝 WalkthroughWalkthroughAdds a new spock-spring Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client
participant MockMvc as MockMvc/Test
participant Controller as HelloWorldController
participant Service as HelloWorldService
participant App as SimpleBootApp
Client->>MockMvc: GET /
MockMvc->>Controller: invoke hello()
Controller->>Service: getHelloMessage()
Service-->>Controller: "Hello Spock"
Controller-->>MockMvc: response "Hello Spock"
MockMvc-->>Client: 200 "Hello Spock"
sequenceDiagram
participant TestRunner as TestRunner
participant Spring as SpringBootTest
participant Repo as BookRepository
participant H2 as Embedded DB
TestRunner->>Spring: start test context (SimpleBootApp)
Spring->>Repo: inject BookRepository
TestRunner->>Repo: save(Book), save(Book)
Repo->>H2: persist entities
H2-->>Repo: persisted
TestRunner->>Repo: count()
Repo-->>TestRunner: 2
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds a new Key changes:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
SG[settings.gradle - non-Groovy-2.5 block] --> B3[spock-spring:boot3-test]
SG --> B4[spock-spring:boot4-test]
SG --> S6[spock-spring:spring6-test]
B4 --> GRADLE[boot4-test.gradle - Spring Boot 4.0.3]
GRADLE --> DEPS[New test starters - data-jpa-test and webmvc-test]
B4 --> MAIN[Main sources]
MAIN --> M1[SimpleBootApp]
MAIN --> M2[HelloWorldService]
MAIN --> M3[ScopedHelloWorldService]
MAIN --> M4[HelloWorldController]
MAIN --> M5[Book and BookRepository]
B4 --> TESTS[Test specs]
TESTS --> T1[SimpleBootAppIntegrationSpec]
TESTS --> T2[SpringBootTestAnnotationIntegrationSpec]
TESTS --> T3[SpringBeanIntegrationSpec]
TESTS --> T4[WebMvcTestIntegrationSpec]
TESTS --> T5[DataJpaTestIntegrationSpec]
TESTS --> T6[SpringBootTestAnnotationScopedMockSpec]
TESTS --> T7[SpringBootTestAnnotationScopedProxyMockSpec]
Last reviewed commit: aa7c7ed |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+24
to
+25
| import org.springframework.boot.data.jpa.test.autoconfigure.DataJpaTest | ||
| import org.springframework.boot.jpa.test.autoconfigure.TestEntityManager |
There was a problem hiding this comment.
Inconsistent package roots for JPA test imports
DataJpaTest is imported from org.springframework.boot.data.jpa.test.autoconfigure while TestEntityManager is imported from org.springframework.boot.jpa.test.autoconfigure — note the difference: data.jpa vs jpa. This inconsistency in the package root is worth verifying against the actual Spring Boot 4 module layout. If both classes ship in the same artifact (spring-boot-starter-data-jpa-test), they are likely in the same or a closely related package tree, and one of these imports may be wrong. The boot3 analogue imported both from org.springframework.boot.test.autoconfigure.orm.jpa.* with a single wildcard import, which naturally avoided this kind of mismatch.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedProxyMockSpec.groovy (1)
52-55: Use Spring's proxy detection API instead of hard-coded internal bean names and generated class prefixes.The
scopedTarget.helloWorldServicelookup and$$SpringCGLIB$$class name prefix check depend on Spring Framework internals and generated class naming conventions. Spring provides standard testing utilities for this:AopUtils.isCglibProxy()to check proxy type semantically, andAopTestUtils.getTargetObject()to safely unwrap the target from the proxy. This pattern appears across the boot2, boot3, and boot4 test suites and should use the standard APIs instead.Suggested change
- def helloWorldServiceMock = context.getBean("scopedTarget.helloWorldService") as HelloWorldService + def helloWorldServiceMock = AopTestUtils.getTargetObject(helloWorldService) expect: - helloWorldService.class.simpleName.startsWith('HelloWorldService$$SpringCGLIB$$') + AopUtils.isCglibProxy(helloWorldService)Add imports:
import org.springframework.aop.support.AopUtils import org.springframework.test.util.AopTestUtils🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedProxyMockSpec.groovy` around lines 52 - 55, Replace the brittle internal lookup and name-prefix assertion by using Spring's proxy utilities: stop fetching the bean via context.getBean("scopedTarget.helloWorldService") and stop asserting on helloWorldService.class.simpleName; instead import and use AopUtils.isCglibProxy(helloWorldService) to assert it's a CGLIB proxy and use AopTestUtils.getTargetObject(helloWorldService) to obtain/unwrap the target for any further assertions (update references to helloWorldServiceMock/helloWorldService accordingly).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationIntegrationSpec.groovy`:
- Around line 31-32: The test enables bean definition overriding in the
`@SpringBootTest` annotation (in SpringBootTestAnnotationIntegrationSpec) by
setting the property 'spring.main.allow-bean-definition-overriding=true'; remove
that property from the annotation so the context fails fast on accidental
duplicate beans (i.e., edit the `@SpringBootTest`(...) on the class to drop the
properties array or remove that entry), then re-run the spec to ensure startup
still succeeds.
In
`@spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedMockSpec.groovy`:
- Around line 32-33: The test currently uses `@ScanScopedBeans` but tests a
singleton replacement bean (MockConfig.helloWorldService()), so it doesn't
actually verify scoped scanning; either change the replacement bean to a
non-singleton scope (e.g., annotate MockConfig.helloWorldService() as
`@Scope`("prototype") or use a scoped annotation used by
SpringMockTestExecutionListener) and update assertions to target that scoped
bean, or remove `@ScanScopedBeans` from the spec and rename the test class/methods
to indicate it's validating singleton/mock replacement behavior (adjust any
other occurrences at the same locations noted around lines 62-68 accordingly).
---
Nitpick comments:
In
`@spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedProxyMockSpec.groovy`:
- Around line 52-55: Replace the brittle internal lookup and name-prefix
assertion by using Spring's proxy utilities: stop fetching the bean via
context.getBean("scopedTarget.helloWorldService") and stop asserting on
helloWorldService.class.simpleName; instead import and use
AopUtils.isCglibProxy(helloWorldService) to assert it's a CGLIB proxy and use
AopTestUtils.getTargetObject(helloWorldService) to obtain/unwrap the target for
any further assertions (update references to
helloWorldServiceMock/helloWorldService accordingly).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2a080b41-a247-4a01-aaae-43aa1a5f18bf
📒 Files selected for processing (16)
settings.gradlespock-spring/boot4-test/boot4-test.gradlespock-spring/boot4-test/src/main/java/org/spockframework/boot4/SimpleBootApp.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/jpa/Book.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/jpa/BookRepository.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/service/HelloWorldService.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/service/ScopedHelloWorldService.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/web/HelloWorldController.javaspock-spring/boot4-test/src/main/resources/application.propertiesspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/DataJpaTestIntegrationSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SimpleBootAppIntegrationSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBeanIntegrationSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationIntegrationSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedMockSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedProxyMockSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/WebMvcTestIntegrationSpec.groovy
Comment on lines
+31
to
+32
| @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE, | ||
| properties = ['spring.main.allow-bean-definition-overriding=true']) |
There was a problem hiding this comment.
Drop bean overriding from this context-load spec.
Nothing in this spec replaces application beans, so enabling spring.main.allow-bean-definition-overriding only weakens the test: an accidental duplicate bean would be silently accepted instead of failing startup.
Suggested cleanup
-@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE,
- properties = ['spring.main.allow-bean-definition-overriding=true'])
+@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE, | |
| properties = ['spring.main.allow-bean-definition-overriding=true']) | |
| `@SpringBootTest`(webEnvironment = SpringBootTest.WebEnvironment.NONE) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationIntegrationSpec.groovy`
around lines 31 - 32, The test enables bean definition overriding in the
`@SpringBootTest` annotation (in SpringBootTestAnnotationIntegrationSpec) by
setting the property 'spring.main.allow-bean-definition-overriding=true'; remove
that property from the annotation so the context fails fast on accidental
duplicate beans (i.e., edit the `@SpringBootTest`(...) on the class to drop the
properties array or remove that entry), then re-run the spec to ensure startup
still succeeds.
Comment on lines
+32
to
+33
| @ScanScopedBeans | ||
| @SpringBootTest(properties = ['spring.main.allow-bean-definition-overriding=true']) |
There was a problem hiding this comment.
@ScanScopedBeans isn't actually under test here.
Per spock-spring/src/main/java/org/spockframework/spring/SpringMockTestExecutionListener.java:94-103, singleton bean definitions are attached even without @ScanScopedBeans; only non-singletons take the scoped-scan path. Since MockConfig.helloWorldService() is a plain singleton @Bean, this spec would still pass if scoped-bean scanning regressed.
Either make the replacement bean scoped or point the assertions at an actual scoped mock; otherwise this should drop @ScanScopedBeans and be renamed to reflect the non-scoped case.
Also applies to: 62-68
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedMockSpec.groovy`
around lines 32 - 33, The test currently uses `@ScanScopedBeans` but tests a
singleton replacement bean (MockConfig.helloWorldService()), so it doesn't
actually verify scoped scanning; either change the replacement bean to a
non-singleton scope (e.g., annotate MockConfig.helloWorldService() as
`@Scope`("prototype") or use a scoped annotation used by
SpringMockTestExecutionListener) and update assertions to target that scoped
bean, or remove `@ScanScopedBeans` from the spec and rename the test class/methods
to indicate it's validating singleton/mock replacement behavior (adjust any
other occurrences at the same locations noted around lines 62-68 accordingly).
There was a problem hiding this comment.
♻️ Duplicate comments (1)
spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationIntegrationSpec.groovy (1)
31-32:⚠️ Potential issue | 🟡 MinorRemove bean-definition overriding from this spec.
Line 31-32 enables bean overriding even though this spec does not replace beans, which can hide accidental duplicate bean registrations.
Suggested cleanup
-@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE, - properties = ['spring.main.allow-bean-definition-overriding=true']) +@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationIntegrationSpec.groovy` around lines 31 - 32, The `@SpringBootTest` annotation on SpringBootTestAnnotationIntegrationSpec currently sets properties = ['spring.main.allow-bean-definition-overriding=true']; remove that properties attribute (or at least remove the 'spring.main.allow-bean-definition-overriding' entry) so the test no longer enables bean-definition overriding; update the class annotation (`@SpringBootTest`) accordingly to rely on default behavior and avoid hiding duplicate bean registrations.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In
`@spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationIntegrationSpec.groovy`:
- Around line 31-32: The `@SpringBootTest` annotation on
SpringBootTestAnnotationIntegrationSpec currently sets properties =
['spring.main.allow-bean-definition-overriding=true']; remove that properties
attribute (or at least remove the 'spring.main.allow-bean-definition-overriding'
entry) so the test no longer enables bean-definition overriding; update the
class annotation (`@SpringBootTest`) accordingly to rely on default behavior and
avoid hiding duplicate bean registrations.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 644e3f3e-4e26-4ebc-9b12-d49615830984
📒 Files selected for processing (16)
settings.gradlespock-spring/boot4-test/boot4-test.gradlespock-spring/boot4-test/src/main/java/org/spockframework/boot4/SimpleBootApp.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/jpa/Book.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/jpa/BookRepository.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/service/HelloWorldService.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/service/ScopedHelloWorldService.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/web/HelloWorldController.javaspock-spring/boot4-test/src/main/resources/application.propertiesspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/DataJpaTestIntegrationSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SimpleBootAppIntegrationSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBeanIntegrationSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationIntegrationSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedMockSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedProxyMockSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/WebMvcTestIntegrationSpec.groovy
✅ Files skipped from review due to trivial changes (6)
- spock-spring/boot4-test/src/main/resources/application.properties
- settings.gradle
- spock-spring/boot4-test/src/main/java/org/spockframework/boot4/jpa/Book.java
- spock-spring/boot4-test/src/main/java/org/spockframework/boot4/jpa/BookRepository.java
- spock-spring/boot4-test/src/main/java/org/spockframework/boot4/service/HelloWorldService.java
- spock-spring/boot4-test/src/main/java/org/spockframework/boot4/service/ScopedHelloWorldService.java
🚧 Files skipped from review as they are similar to previous changes (7)
- spock-spring/boot4-test/src/main/java/org/spockframework/boot4/SimpleBootApp.java
- spock-spring/boot4-test/src/main/java/org/spockframework/boot4/web/HelloWorldController.java
- spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/WebMvcTestIntegrationSpec.groovy
- spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBeanIntegrationSpec.groovy
- spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedProxyMockSpec.groovy
- spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedMockSpec.groovy
- spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/DataJpaTestIntegrationSpec.groovy
This comment has been minimized.
This comment has been minimized.
🔎 No tests executed 🔎🏷️ Commit: 893084a Learn more about TestLens at testlens.app. |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedMockSpec.groovy (1)
32-33:⚠️ Potential issue | 🟠 Major
@ScanScopedBeansis still not actually under test here.Line 32 enables scoped scanning, but Line 67 defines a default singleton bean, and Line 45 explicitly expects no
scopedTarget.helloWorldService. This validates singleton override behavior, not the scoped-bean scan path.Please either (a) make the replacement bean scoped and assert scoped-target behavior, or (b) remove
@ScanScopedBeansand rename the spec to match singleton mock replacement intent.#!/bin/bash set -euo pipefail echo "Verify how scoped scanning is gated in the listener:" rg -n -C4 'ScanScopedBeans|singleton|scoped|attach.*definition|BeanDefinition' \ spock-spring/src/main/java/org/spockframework/spring/SpringMockTestExecutionListener.java echo echo "Verify this spec currently defines a singleton replacement bean and asserts no scopedTarget bean:" rg -n -C3 '@ScanScopedBeans|containsBean\\("scopedTarget\\.helloWorldService"\\)|@Bean|HelloWorldService helloWorldService\\(' \ spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedMockSpec.groovyAlso applies to: 45-46, 62-69
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedMockSpec.groovy` around lines 32 - 33, The test currently enables `@ScanScopedBeans` but defines a singleton replacement bean via the helloWorldService `@Bean` and asserts absence of "scopedTarget.helloWorldService", so the scoped-scan path isn't exercised; either change the replacement bean to a scoped bean (e.g., make the bean definition use the same scope that ScanScopedBeans targets so the container registers a scopedTarget bean) and update the assertions in SpringBootTestAnnotationScopedMockSpec to expect and verify "scopedTarget.helloWorldService" behavior, or remove `@ScanScopedBeans` and rename the spec to reflect singleton replacement intent (keep the helloWorldService `@Bean` and the existing containsBean("scopedTarget.helloWorldService") negative assertion). Ensure you update references to helloWorldService, the test class SpringBootTestAnnotationScopedMockSpec, and the containsBean("scopedTarget.helloWorldService") assertion accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In
`@spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedMockSpec.groovy`:
- Around line 32-33: The test currently enables `@ScanScopedBeans` but defines a
singleton replacement bean via the helloWorldService `@Bean` and asserts absence
of "scopedTarget.helloWorldService", so the scoped-scan path isn't exercised;
either change the replacement bean to a scoped bean (e.g., make the bean
definition use the same scope that ScanScopedBeans targets so the container
registers a scopedTarget bean) and update the assertions in
SpringBootTestAnnotationScopedMockSpec to expect and verify
"scopedTarget.helloWorldService" behavior, or remove `@ScanScopedBeans` and rename
the spec to reflect singleton replacement intent (keep the helloWorldService
`@Bean` and the existing containsBean("scopedTarget.helloWorldService") negative
assertion). Ensure you update references to helloWorldService, the test class
SpringBootTestAnnotationScopedMockSpec, and the
containsBean("scopedTarget.helloWorldService") assertion accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b11fcf94-f4e6-4586-8fd9-842adaca4b3d
📒 Files selected for processing (16)
settings.gradlespock-spring/boot4-test/boot4-test.gradlespock-spring/boot4-test/src/main/java/org/spockframework/boot4/SimpleBootApp.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/jpa/Book.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/jpa/BookRepository.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/service/HelloWorldService.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/service/ScopedHelloWorldService.javaspock-spring/boot4-test/src/main/java/org/spockframework/boot4/web/HelloWorldController.javaspock-spring/boot4-test/src/main/resources/application.propertiesspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/DataJpaTestIntegrationSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SimpleBootAppIntegrationSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBeanIntegrationSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationIntegrationSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedMockSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedProxyMockSpec.groovyspock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/WebMvcTestIntegrationSpec.groovy
✅ Files skipped from review due to trivial changes (8)
- spock-spring/boot4-test/src/main/resources/application.properties
- spock-spring/boot4-test/src/main/java/org/spockframework/boot4/jpa/Book.java
- spock-spring/boot4-test/src/main/java/org/spockframework/boot4/jpa/BookRepository.java
- spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SimpleBootAppIntegrationSpec.groovy
- spock-spring/boot4-test/src/main/java/org/spockframework/boot4/web/HelloWorldController.java
- spock-spring/boot4-test/src/main/java/org/spockframework/boot4/SimpleBootApp.java
- spock-spring/boot4-test/src/main/java/org/spockframework/boot4/service/ScopedHelloWorldService.java
- spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/DataJpaTestIntegrationSpec.groovy
🚧 Files skipped from review as they are similar to previous changes (6)
- settings.gradle
- spock-spring/boot4-test/src/main/java/org/spockframework/boot4/service/HelloWorldService.java
- spock-spring/boot4-test/boot4-test.gradle
- spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationIntegrationSpec.groovy
- spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBeanIntegrationSpec.groovy
- spock-spring/boot4-test/src/test/groovy/org/spockframework/boot4/SpringBootTestAnnotationScopedProxyMockSpec.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Tests